Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug handling test notification #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

miedda
Copy link

@miedda miedda commented Dec 3, 2023

This commit adds checks to verify that the notification has non-empty strings in the SignedTransactionInfo and SignedRenewalInfo fields. This check allows the test notification, which does have values for these fields to be populated. Without these checks a panic occurs as the tokens for the fields cannot be parsed correctly.

This commit adds checks to verify that the notification has non-empty strings in the SignedTransactionInfo and SignedRenewalInfo fields.
This check allows the test notification, which does have values for these fields to be populated.
@izniburak
Copy link
Owner

Hi @miedda ,
Thanks for your contribution. Could you please also write a test for your updates?

Thanks.

@miedda
Copy link
Author

miedda commented Dec 4, 2023

I have added a test as requested. I have followed the same pattern as the existing test, and am pulling the request from the local environment. It needs to be generated by requesting a test notification via the app store server API. I also had to modify the existing test to skip if the environment variables are not available.

@pfm-hampus
Copy link

Hello contributors!
Just tried this golang package and also noticed the panic when testing it with apples TestNotification. Do you have any ETA on this release?

@izniburak
Copy link
Owner

Hi @pfm-hampus ,
I would merge this PR, but wrong files/lines have been changed in the PR. So, I'll prepare a new PR for the TestNotifications ASAP. Please wait for the next release!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants