-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug handling test notification #1
base: main
Are you sure you want to change the base?
Conversation
This commit adds checks to verify that the notification has non-empty strings in the SignedTransactionInfo and SignedRenewalInfo fields. This check allows the test notification, which does have values for these fields to be populated.
Hi @miedda , Thanks. |
I have added a test as requested. I have followed the same pattern as the existing test, and am pulling the request from the local environment. It needs to be generated by requesting a test notification via the app store server API. I also had to modify the existing test to skip if the environment variables are not available. |
Make the fork usable from its new location
Update go.mod
Hello contributors! |
Hi @pfm-hampus , Thanks. |
This commit adds checks to verify that the notification has non-empty strings in the SignedTransactionInfo and SignedRenewalInfo fields. This check allows the test notification, which does have values for these fields to be populated. Without these checks a panic occurs as the tokens for the fields cannot be parsed correctly.