Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IZPACK-1180] ConfigurationInstallerListener: Nested <entry> remains empty if it didn't exist before #291

Merged
merged 1 commit into from Nov 7, 2014

Conversation

rkrell
Copy link
Member

@rkrell rkrell commented Nov 7, 2014

Fixes https://jira.codehaus.org/browse/IZPACK-1180:

If a property file is created by ConfigurationListener, or nested doesn't still exist before applyiong configuration actions, the nested entries are left empty and their value attribute isn't applied at all.
Example

<configurable type="options" keepOldKeys="true" keepOldValues="true" tofile="${INSTALL_PATH}/db.properties">
        <entry key="driver" value="org.firebirdsql.jdbc.FBDriver" />
        <entry key="url" value="jdbc:firebirdsql:${db.host}/${db.port}:##user.dir#/" />
        <entry key="file" value="${database.scriptsfolder}/${db.name}.fdb" />
        <entry key="user" value="${db.user}" />
        <entry key="pass" value="${db.password}" />
</configurable>

if db.properties doesn't exist the ConfigurationInstallerListener leaves it in this state:

driver=
url=
file=
user=
pass=

@buildhive
Copy link

IzPack project » izpack #646 SUCCESS
This pull request looks good
(what's this?)

rkrell added a commit that referenced this pull request Nov 7, 2014
[IZPACK-1180] ConfigurationInstallerListener: Nested <entry> remains empty if it didn't exist before
@rkrell rkrell merged commit 40a713e into izpack:master Nov 7, 2014
@rkrell rkrell deleted the IZPACK-1180 branch November 7, 2014 15:48
@rkrell rkrell added this to the 5.0 RC5 milestone Nov 7, 2014
@rkrell rkrell self-assigned this Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants