Izpack 1182: Evaluation of dynamic variables, which depends on other ones #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state is reached. This is important for dynamic variables, which depend on other dynamic variables.
state is reached. This is important for dynamic variables, which depend
on other dynamic variables.
A dynamic variable with checkonce="true" can be updated several times
during ONE SINGLE call of DefaultVariables.refresh() and should be fixed
("checked") at the end of this refresh(), not during the refresh().
|
IzPack project » izpack #679 SUCCESS |
|
Unfortunately this breaks the latest implementation of blocking variables reserved by panels. |
http://docs.codehaus.org/display/IZPACK/Lifecycle+of+dynamic+variables <dynamicvariables> <variable name="thechoice" value="fallback value" /> <variable name="thechoice" value="choice1" condition="cond1" /> <variable name="thechoice" value="choice2" condition="cond2" /> </dynamicvariables> <conditions> <condition type="variable" id="cond1"> <name>condvar1</name> <value>1</value> </condition> <condition type="variable" id="cond2"> <name>condvar1</name> <value>1</value> </condition> </conditions>
(will become better readable after the next change)
different condition the check for "changed" must be done after all dynamicvariables have been computated.
|
IzPack project » izpack #680 SUCCESS |
|
The last update does resolve a loop for a variable with several conditions. |
|
I'll check this soon, but it should not break older environments, relying on the order of definition of the dynamic variables. Thanks for your action. |
rkrell
added a commit
that referenced
this pull request
Jan 30, 2015
Izpack 1182: Evaluation of dynamic variables, which depends on other ones
|
It works so far, well-done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix the dynamic variables, which depend on other ones, are computated correct on the first refresh() already. The Issue is olved with this pull request.