Allow function options and support deferred benchmarks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +161,12 @@ BenchTable.prototype = Object.create(Benchmark.Suite.prototype); | |||
| BenchTable.prototype.run = function(config) { | |||
| var self = this, mapkey, mapfun; | |||
|
|
|||
| function createBenchmarkFunction(fun, input) { | |||
| function createBenchmarkFunction(fun, options, input) { | |||
There was a problem hiding this comment.
What do you think about moving the options parameter to the last place? Just wondering if there's a reason you put it in 2nd place here, and in last place in addFunction. 💭
There was a problem hiding this comment.
No real preference there. I chose to keep fun and options next to each other similarly to addFunction. This is an internal function only, so I have no problem switching it.
There was a problem hiding this comment.
It's fine -- thanks again for this! Just published v0.0.5 on npm. 🏄
|
Thanks for the PR, @mridgway -- just have one question, but otherwise happy to merge this. 👍 |
izuzak
added a commit
that referenced
this pull request
Jun 1, 2015
Allow function options and support deferred benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tests with
deferand other options.