Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a registered user, having created and configured a feed, I can now use keywords to build pages #8

Closed
j-000 opened this issue Jul 29, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@j-000
Copy link
Owner

j-000 commented Jul 29, 2023

Success criteria:

  1. Can use reserved words as per mappings
  2. Can use control flow helper (if, else)
  3. Can use partials
@j-000 j-000 self-assigned this Jul 29, 2023
@j-000 j-000 added the enhancement New feature or request label Jul 29, 2023
j-000 added a commit that referenced this issue Jul 29, 2023
j-000 added a commit that referenced this issue Jul 29, 2023
j-000 added a commit that referenced this issue Jul 29, 2023
j-000 added a commit that referenced this issue Jul 29, 2023
@j-000
Copy link
Owner Author

j-000 commented Jul 31, 2023

1 is complete

j-000 added a commit that referenced this issue Jul 31, 2023
@j-000
Copy link
Owner Author

j-000 commented Jul 31, 2023

Nunjucks doesn't condone user-defined templates 😢
mozilla/nunjucks-docs#17

May need to show an alert on the app and restrict this feature to "trusted" users.

It may be coming as a feature to nunjucks w3c/webextensions#18

@j-000 j-000 changed the title As a registered user, having created and configured a feed, I can now use keywords to build custom templates (BDJP, ADJP and SRP). As a registered user, having created and configured a feed, I can now use keywords to build pages Aug 1, 2023
@j-000
Copy link
Owner Author

j-000 commented Aug 1, 2023

2 is done - Can use control flow
3 is done - Can use partials.

@j-000
Copy link
Owner Author

j-000 commented Aug 1, 2023

2 and 3 are out of the box when using nunjucks.
It may be wise to limit control flow and partials to trusted users (admins) for example.

@j-000 j-000 closed this as completed Aug 1, 2023
j-000 added a commit that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🥳
Development

No branches or pull requests

1 participant