feat: add entity with entity_picture as an image source
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Daanoz ! |
|
Thanks for the merge @j-a-n, if any issues arise, feel free to tag me, happy to take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm the creator of the Google Photos integration which exposes images in a Google Photos album as a
cameraentity in Home Assistant. This allows me to use images from any personal album in all kinds of Home Assistant extensions.I have extended your implementation to also accept entity ids, that can be used as an image source when they have the
entity_pictureattribute, I have tried to keep the implementation as generic as possible so it can be used for any entity supporting the attribute whilst staying close to your original implementation.Let me know if you consider this to big of a change, I can try making it smaller or just fork off into a separate extension.