Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Conference only" filter in KenPom Scouting Reports #63

Closed
ddogwoofwoof opened this issue Oct 23, 2023 · 5 comments
Closed

"Conference only" filter in KenPom Scouting Reports #63

ddogwoofwoof opened this issue Oct 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ddogwoofwoof
Copy link

In KenPom's scouting reports, there is a "Conference only" filter. Unfortunately, I don't see this filter option using the summary.py file. Do you know if this is possible to include? I inspected KenPom's website, but struggled to find the elements that include this info.
Thank you!
Derek

@j-andrews7
Copy link
Owner

j-andrews7 commented Oct 23, 2023 via email

@ddogwoofwoof
Copy link
Author

That makes sense. I'll take a stab at it as well and create a pull request if I can make progress. Thank you!

@esqew
Copy link
Collaborator

esqew commented Oct 24, 2023

I believe what you're referring to is something that has already had work put forward in #40. It's currently stalled for a variety of reasons, the biggest of which being that I'm not convinced we should take additional overhead to execute arbitrary JavaScript for support of such a small sliver of the site.

I have a local branch where I've tried to do this purely with the current dependency set and parsing some of the JS content with a thoughtful RegExp but it's not yet all the way there.

If you are so inclined, please feel free to try to pull together a PR and we'd be more than happy to consider it.

@esqew esqew added the enhancement New feature or request label Oct 24, 2023
@esqew
Copy link
Collaborator

esqew commented Oct 24, 2023

I have a local branch where I've tried to do this purely with the current dependency set and parsing some of the JS content with a thoughtful RegExp but it's not yet all the way there.

I just now remembered my attempt at this has actually been pushed to the enhancement/team-scouting-report branch. I don't recall exactly how much more work is required to get this ready for release (it may be as little as some test coverage?), but the fundamental underpinnings are there if you want to build off that.

If not, I will try my best to get back around to this soon.

@ddogwoofwoof
Copy link
Author

@esqew this is perfect!! Thank you so much for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants