Vectorize temporal superposition #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 14, 2021 16:42
related to #15 The biggest problem with the code right now appears to be the containers not all being 1D. I propose creating an "ideal" temporal super position function and performing timing tests on that to compare to what originally existed.
This was
linked to
issues
May 15, 2021
|
Commit fcc6ab5 provides a significant performance improvement. The table from #14 (comment) is recreated comparing timings of the tests for the most recent release ( This implementation assumes all segments lengths are the same. They are, and may always be, but this should be taken into consideration. It will be possible to consider differing segment lengths in the future, but now and possibly the merge of this branch will create a new issue. There is still quite a bit of work to be done along this line, so the speed improvements will be more in the future of this branch. |
This was referenced May 15, 2021
The temporal superposition function has been made final by creating the desired 1D vectors beforehand and passing them in. This brings about some unnecessary overhead and memory consumption that will be addressed in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
temporal_superpositionfunction is the primary bottleneck holding backcpgfunctionfrom leavingpygfunctionin the dust as far as a comparison of speed goes. The function needs vectorized so the time to solve the problem does not grow so heavily as the size of the problem becomes larger.