Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Display info regarding new available version when used with -y flag #27

Closed
Celleb opened this issue Sep 7, 2020 · 4 comments

Comments

@Celleb
Copy link
Contributor

Celleb commented Sep 7, 2020

Currently, the -y stops the version check, but I will be nice if it will check and just display a new version message without stopping the build, and possibly a link to the release notes. In this case, I'll know there's a new version and I'll update when I see fit. @p-mcgowan

@p-mcgowan
Copy link
Contributor

yeah that's a good call.
In this case, I think it would be good to have 2 setups here - 1 for skip and ignore, and 1 for auto yes.

The reason being - while running tests, if you allow it to ping the remote every time, it can be slow. In this case, we could keep the NODE_ENV=test workaround for skipping it completely, but the --yes here could still do the check, but just report the difference.
In this case, I think a simple remote version check would suffice, or even a basic http call. Otherwise we may need to dig into the version checker and find out if it's easy to pass in some flags / env vars to disable it at certain points.

@Acrontum-Carmichael
Copy link
Contributor

the npm version checker could easily be extended - might be a simpler solution.. open to changing it

@p-mcgowan
Copy link
Contributor

I don't think the CI pipe was an issue - that we could use the new --yes flag for.

I initially hardcoded in if (process.env.NODE_ENV === 'test') { <skip thinger> } because it messed with running tests. It makes sense (in my mind at least) that in test env, it should not check for updates, and when not in test env, you can disable the complaining by --yes'ing it out. I think that should cover the use cases

p-mcgowan added a commit that referenced this issue Sep 7, 2020
@p-mcgowan
Copy link
Contributor

close in #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants