You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The DelimitedRecordMapper and XmlRecordMarshaller take the target type as parameter, while the BeanValidationRecordValidator is generic and is parametrized with the target type.
Looking at the implementation of BeanValidationRecordValidator, ConstraintViolation is the root origin of genericity needs, but methods called on it does not use the generic type. Hence, the generic type can be removed form BeanValidationRecordValidator.
The text was updated successfully, but these errors were encountered:
fmbenhassine
changed the title
BeanValidationRecordValidator should take the validated type as parameter
Unnecessary generic type for BeanValidationRecordValidator
Sep 8, 2016
fmbenhassine
changed the title
Unnecessary generic type for BeanValidationRecordValidator
Unnecessary generic type in BeanValidationRecordValidator
Sep 27, 2016
The following example shows incoherence in API design:
The
DelimitedRecordMapper
andXmlRecordMarshaller
take the target type as parameter, while theBeanValidationRecordValidator
is generic and is parametrized with the target type.Looking at the implementation of
BeanValidationRecordValidator
,ConstraintViolation
is the root origin of genericity needs, but methods called on it does not use the generic type. Hence, the generic type can be removed formBeanValidationRecordValidator
.The text was updated successfully, but these errors were encountered: