-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert PipelineListener call order #280
Comments
Hello, Interesting! I think listeners should behave as you suggest. Have you considered migrating to v5? I can help! Kr |
Hi @benas , I yet don't try migrate to version 5.x, Next weeks I will. Thanks by you consider the new behavior for next version. :) |
Hi @marcosvpcortes Thank you for both pull requests! I don't know why I was not notified about them.. Please note that 'production' branches cannot receive pull requests, they are updated only by the release process. As discussed, v4 is obsolete, so I closed the PR related to it. But the one for v5 is great! I did a quick review and it good to merge. Many thanks for your effort! Kind regards |
Hi @marcosvpcortes I would like to merge your PR and include it in v5.2. Kr |
Hi @marcosvpcortes I applied your changes to the master branch and added you to the contributors list. I've deployed v5.2.0-SNAPSHOT with your changes. This feature will go in the upcoming release. Keep tuned 😉 Best regards, |
Hi @benas, Kr, Marcos Côrtes |
No worries, it will be included in next release. Keep tuned 😄 |
Hello,
I would require a new behavior for 4.2.2 version.
I am using Spring to manager transactions in my batch processing. I need do fine-tuning transactions by programmatic transaction (http://docs.spring.io/spring-framework/docs/current/spring-framework-reference/html/transaction.html#transaction-programmatic-ptm)
To nested transactions, I need that PipelineListener methods (beforeRecordProcessing, afterRecordProcessing) be called in a certain order. If the pipelines a, b and c are registered in this order, then the beforeRecordProcessing methods should be called in same order (a.beforeRecordProcessing, b.beforeRecordProcessing, c.beforeRecordProcessing), and the afterRecordProcessing should be called in inverse order (c.afterRecordProcessing, b.afterRecordProcessing, a.afterRecordProcessing).
a.beforeRecordProcessing
b.beforeRecordProcessing
c.beforeRecordProcessing
(pipeline processing)
c.afterRecordProcessing
b.afterRecordProcessing
a.afterRecordProcessing
Thanks
The text was updated successfully, but these errors were encountered: