issue #288 : add failing test

j-easy · Dec 6, 2017 · ee247bb · ee247bb
1 parent d574501
commit ee247bb
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/...ion/src/test/java/io/github/benas/randombeans/validation/BeanValidationAnnotatedBean.java b/...ion/src/test/java/io/github/benas/randombeans/validation/BeanValidationAnnotatedBean.java
@@ -41,6 +41,10 @@ class BeanValidationAnnotatedBean {
     @DecimalMin("5.00")
     private BigDecimal minDiscount;
 
+    @DecimalMax("1.00")
+    @DecimalMin("0.01")
+    private BigDecimal discount;
+
     @Future
     private Date eventDate;
 
@@ -165,7 +169,15 @@ public void setRegexString(String regexString) {
 		this.regexString = regexString;
 	}
 
-	@Override
+    public BigDecimal getDiscount() {
+        return discount;
+    }
+
+    public void setDiscount(BigDecimal discount) {
+        this.discount = discount;
+    }
+
+    @Override
     public String toString() {
         final StringBuilder sb = new StringBuilder("BeanValidationAnnotatedBean{");
         sb.append("unsupported=").append(unsupported);

diff --git a/...c/test/java/io/github/benas/randombeans/validation/BeanValidationMethodAnnotatedBean.java b/...c/test/java/io/github/benas/randombeans/validation/BeanValidationMethodAnnotatedBean.java
@@ -37,6 +37,8 @@ class BeanValidationMethodAnnotatedBean {
 
     private BigDecimal minDiscount;
 
+    private BigDecimal discount;
+
     private Date eventDate;
 
     private Date birthday;
@@ -85,6 +87,16 @@ public BigDecimal getMinDiscount() {
         return minDiscount;
     }
 
+    @DecimalMax("1.00")
+    @DecimalMin("0.01")
+    public BigDecimal getDiscount() {
+        return discount;
+    }
+
+    public void setDiscount(BigDecimal discount) {
+        this.discount = discount;
+    }
+
     public void setMinDiscount(BigDecimal minDiscount) {
         this.minDiscount = minDiscount;
     }

diff --git a/...s-validation/src/test/java/io/github/benas/randombeans/validation/BeanValidationTest.java b/...s-validation/src/test/java/io/github/benas/randombeans/validation/BeanValidationTest.java
@@ -75,6 +75,9 @@ public void generatedValuesShouldBeValidAccordingToValidationConstraints() {
 
         assertThat(bean.getMinDiscount()).isGreaterThanOrEqualTo(new BigDecimal("5.00"));// @DecimalMin("5.00") BigDecimal minDiscount;
 
+        assertThat(bean.getDiscount()).isLessThanOrEqualTo(new BigDecimal("1.00"));// @DecimalMax("1.00") BigDecimal discount;
+        assertThat(bean.getDiscount()).isGreaterThanOrEqualTo(new BigDecimal("0.01"));// @DecimalMin("0.01") BigDecimal discount;
+
         assertThat(bean.getMinQuantity()).isGreaterThanOrEqualTo(5);// @Min(5) int minQuantity;
 
         assertThat(bean.getBriefMessage().length()).isBetween(2, 10);// @Size(min=2, max=10) String briefMessage;
@@ -108,6 +111,9 @@ public void generatedValuesShouldBeValidAccordingToValidationConstraintsOnMethod
 
         assertThat(bean.getMinDiscount()).isGreaterThanOrEqualTo(new BigDecimal("5.00"));// @DecimalMin("5.00") BigDecimal minDiscount;
 
+        assertThat(bean.getDiscount()).isLessThanOrEqualTo(new BigDecimal("1.00"));// @DecimalMax("1.00") BigDecimal discount;
+        assertThat(bean.getDiscount()).isGreaterThanOrEqualTo(new BigDecimal("0.01"));// @DecimalMin("0.01") BigDecimal discount;
+
         assertThat(bean.getMinQuantity()).isGreaterThanOrEqualTo(5);// @Min(5) int minQuantity;
 
         assertThat(bean.getBriefMessage().length()).isBetween(2, 10);// @Size(min=2, max=10) String briefMessage;
@@ -137,6 +143,7 @@ public void shouldGenerateTheSameValueForTheSameSeed() {
         assertThat(bean.getMinQuantity()).isEqualTo(91531906);
         assertThat(bean.getMaxDiscount()).isEqualTo(new BigDecimal(30));
         assertThat(bean.getMinDiscount()).isEqualTo(new BigDecimal(393126525614007301L));
+        //assertThat(bean.getDiscount()).isEqualTo(new BigDecimal(/* todo add assertion on actual value with the current seed */));
         assertThat(bean.getMinQuantity()).isEqualTo(91531906);
         assertThat(bean.getBriefMessage()).isEqualTo("tguu");
         assertThat(bean.getRegexString()).isEqualTo("vuna");