Pass properly updated context to a ContextAwareRandomizer #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These static factory methods were inspired by Effective Java Item 1, but do not provide any added value in this context. This commit should have been part of 735b245
|
LGTM. Rebased and merged as 729420b. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack of the context passed to any
ContextAwareRandomizerviasetRandomizerContext()does not have the actual currently processed field on top, but the enclosing/parent field instead.This makes it impossible in a randomizer to acquire and use the current field metadata to generate a random value (e.g. based on attributes of a custom annotation on it).