Make usage of ClassGraphFacade replacable with custom logic in ReflectionUtils #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionUtils by providing user injectable Function, while retaining ClassGraphFacade's lazy loading semantics. Moves concrete subtype cache to ReflectionUtils.
|
Thank you for your PR. However, why should we make classgraph replaceable? If I follow this reasoning, we should also find a way to make objenesis replaceable, and datafker replaceable as well. If you want to customize the way to scan the classpath for concrete types, you can disable the |
|
This will be resolved with #474. Thank you for your contribution anyway. |
|
My reason behind this change had to do with a requirement in our test stack, where we had to filter classes on the classpath. The solution in #474 (which is not yet merged) should provide the same possibility. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by providing user injectable Function, while retaining ClassGraphFacade's lazy loading semantics.
Moves concrete subtype cache to ReflectionUtils.
Additionally: