Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile colors are buggy on some terminals #43

Closed
j-faria opened this issue Jun 12, 2018 · 5 comments
Closed

Makefile colors are buggy on some terminals #43

j-faria opened this issue Jun 12, 2018 · 5 comments

Comments

@j-faria
Copy link
Owner

j-faria commented Jun 12, 2018

No idea how to test for this...
@jdavidrcamacho
Copy link
Collaborator

Maybe it's because of the palette some people might use in the terminal, not really your fault if its due to that :\

@j-faria
Copy link
Owner Author

j-faria commented Jun 12, 2018

I agree, but we should still fallback to something that looks ok. I mean, not this

\033[0;33m Compiling example \033[0m BL2009

@eggplantbren
Copy link
Collaborator

I'm affected by this issue. Why do we need color at all?

@j-faria
Copy link
Owner Author

j-faria commented Jun 19, 2018 •
edited

Because it looks fancy, is my only argument ¯\_(ツ)_/¯

@eggplantbren
Copy link
Collaborator

eggplantbren commented Jun 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eggplantbren @j-faria @jdavidrcamacho