Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to set a prior on Tc for a known monotransit planet of unknown period #80

Closed
accameron opened this issue Nov 30, 2023 · 5 comments
Assignees

Comments

@accameron
Copy link
Contributor

At present the use of a prior on orbital phase derived from the time of conjunction,Tc,
requires the orbital period to be specified as a parameter of make_prior<Gaussian_from_Tc>

In the case of a known monotransit planet it would be very useful if users could set a prior on the
time of conjunction Tc (say KO_Tcprior) while allowing an uninformative prior on the orbital period, as an
alternative to setting a prior on the mean anomaly at the time of the first observation. For any
individual sample, phi could then be calculated from the current samples of P, Tc, e and omega.

@j-faria
Copy link
Owner

j-faria commented Dec 6, 2023

Hi Andrew!
Indeed, this would be quite useful. I'm thinking of creating a transiting_planet akin to the known_object but which is parameterised directly with Tc instead of the mean anomaly phi. This would then work for mono/duo/multi transits in general.

@j-faria j-faria self-assigned this Dec 6, 2023
@accameron
Copy link
Contributor Author

accameron commented Dec 8, 2023 via email

@karenacollins
Copy link

Yes, I could really use the Tc prior capability too for mono/duo transit work.

@j-faria
Copy link
Owner

j-faria commented May 16, 2024

Hi @accameron, @karenacollins,
The ability to set a prior for $T_c$ is now implemented in the new version of kima that can be found here. There is also a worked through example in the documentation.

I will close this issue for now, but please let me know if you run into any issues with the new version.

@j-faria j-faria closed this as completed May 16, 2024
@karenacollins
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants