Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't open/check replies of media tweets in Feed #14

Closed
4 tasks done
Oleepre opened this issue Jul 18, 2023 · 8 comments
Closed
4 tasks done

[Bug] Can't open/check replies of media tweets in Feed #14

Oleepre opened this issue Jul 18, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@Oleepre
Copy link

Oleepre commented Jul 18, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug, that only occurs in Squawker

Affected version

v3.1.5+300003154

Steps to reproduce the bug

  1. Go to the "Feed" tab.
  2. Find a tweet that only contains an image or a video, and no text whatsoever.
  3. Try to check the replies or open the tweets by clicking on it.

Expected behavior

Currently the Feed doesn't display the Replies icon on tweets, but you can still check them by clicking anywhere on the tweet's text.
Tweets that consist of a single video, image/s should be able to be opened and see the replies as well.

Actual behavior

Since the tweets don't contain any text and there's no dedicated button to open it and see the replies, context, or full thread, they can't be accessed.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

No response

@Oleepre Oleepre added the bug Something isn't working label Jul 18, 2023
@j-fbriere
Copy link
Owner

Do you have a concrete recent example of such a tweet?
I would like to make tests with it to help me do the fix.

@Oleepre
Copy link
Author

Oleepre commented Jul 18, 2023

I can replicate this by adding a single account to a group since tweets there also suffer from the same behavior.
Adding @origins_audio which are all videos with no text
or @PhoneWallpapers that posts only images, to a group and then checking that group.

@j-fbriere
Copy link
Owner

Ok I can test it now, thank you.
There is indeed no place to touch to open the tweet thread itself.
I'm wondering what would be the best way to handle it.
Should a blank line be added on top of each video or image so that by touching this space above, it would open the tweet thread?
Any other suggestion?

@Oleepre
Copy link
Author

Oleepre commented Jul 18, 2023

When navigating a profile, tweets display a "Replies" counter and clicking it opens thread.
So either a button in the same position or a blank line Below the video so it works the same way in profiles, the feed and group.
Alternatively an option to open the thread when tapping the three dots on the top right of each tweet.

@j-fbriere
Copy link
Owner

j-fbriere commented Jul 18, 2023

The reply counter would be perfect but unfortunately since the recent changes by Twitter, I had to use another kind of request for the feed, a legacy request.
That request does not return the reply count in the response, at least currently.
That's why there is no reply counter visible.
nitter has the same problem by the way.
I think that the three dots solution is good, because it would be an option available for all tweets, with or without text. This would be a consistent UI behavior.
Or maybe make the reply counter appear but without any count. That way we could avoid one additional tap (on the three dots) to open the thread.

@j-fbriere
Copy link
Owner

I have added a reply counter without any count for all the tweets in feeds.
Can you install and test the latest ci build and tell me if it fits you need?

@Oleepre
Copy link
Author

Oleepre commented Jul 19, 2023

It seems to work as intended, and it perfectly solves the issue. Thank you.

@j-fbriere
Copy link
Owner

Version 3.1.6 fixes the issue.

@Oleepre Oleepre closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants