Triggers Anti-Root

[Curve]

This magisk module trips the anti-root mechanisms of some banking apps , I believe this is due to mindetach, is it possible to not use mindetach without using the microg version? (see comments)

[mingaldrichgan]

Have you tried disabling/uninstalling the Mindetach module? It isn't required to run Revanced?

[Curve]

Have you tried disabling/uninstalling the Mindetach module? It isn't required to run Revanced?

There is no additional module for mindetach, it's included in the ReVanced Magisk Module

Edit: Also, yes it's currently required but I don't see any reason to give an option to not include it as while it's convenient to disable updates and such, it triggers some anti-root mechanisms of some apps - so I'd rather prefer to disable auto-updates in the Play Store to be able to use my banking app while the ReVanced Magisk Modules are enabled

[mingaldrichgan]

Hmmm I'm confused, as it's a separate .zip file that I flashed (but you don't have to)...

[Curve]

Hmmm I'm confused, as it's a separate .zip file that I flashed (but you don't have to)...

Hm - It's all in one module for me - Would you mind posting your build conf?

[mingaldrichgan]

I'm using the prebuilt ones. Sorry I misunderstood your query.

[Curve]

I'm using the prebuilt ones. Sorry I misunderstood your query.

Ah, don't mind me then I thought it used mindetach the whole time for whatever reason but that's not true.

Still, something in this magisk module causes my banking app to detect root - Which is strange, I doubt it's detecting that the APK was patched somehow, at first I thought that it may be the icon patch of revanced but I disabled that and it still detects root but only if the revanced modules are loaded

What's also strange is that it's only this one app that detects root, safetynet is fine and other banking or root sensitive apps are fine too

[j-hc]

which banking app is that?

[Curve]

which banking app is that?

The PushTan App by Sparkasse

Another interesting observation:

ReVanced Modules not loaded:

=> Banking app works

Revanced Modules loaded:

=> Banking app does not work

Other modules that I have always loaded are:
Universal Safetynet Fix
Shamiko

Modules that once enabled cause magisk to be detected:

YouTube ReVanced
YouTube Music ReVanced

[j-hc]

@Curve can you test this and let me know? it should get rid of the "Found Magisk" in momo but im not sure about the banking app.

https://drive.google.com/file/d/1XzBJMEHxuZj865dU68B1SSFVMQHqfMg5/view?usp=sharing

[Curve]

@Curve can you test this and let me know? it should get rid of the "Found Magisk" in momo but im not sure about the banking app.

https://drive.google.com/file/d/1XzBJMEHxuZj865dU68B1SSFVMQHqfMg5/view?usp=sharing

Works!
Magisk is no longer detected and the banking app works perfectly :)

What was the issue? Can this be mainlined so that I can adjust the patches?

[j-hc]

@Curve can you test this and let me know? it should get rid of the "Found Magisk" in momo but im not sure about the banking app.
https://drive.google.com/file/d/1XzBJMEHxuZj865dU68B1SSFVMQHqfMg5/view?usp=sharing

Works! Magisk is no longer detected and the banking app works perfectly :)

What was the issue? Can this be mainlined so that I can adjust the patches?

the issue was the mount point (maybe selinux context related?), now i hardlink the patched apk in another directory and bind mount from there. thats all.

and im closing the issue, will merge the changes.

[Curve]

@Curve can you test this and let me know? it should get rid of the "Found Magisk" in momo but im not sure about the banking app.
https://drive.google.com/file/d/1XzBJMEHxuZj865dU68B1SSFVMQHqfMg5/view?usp=sharing

Works! Magisk is no longer detected and the banking app works perfectly :)

What was the issue? Can this be mainlined so that I can adjust the patches?

the issue was the mount point (maybe selinux context related?), now i hardlink the patched apk in another directory and bind mount from there. thats all.

and im closing the issue, will merge the changes.

Thanks for the quick reply & fix!