Skip to content
This repository has been archived by the owner on Jun 5, 2021. It is now read-only.

Null safety #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Null safety #18

wants to merge 2 commits into from

Conversation

jonmountjoy
Copy link

@jonmountjoy jonmountjoy commented Mar 4, 2021

Adds null safety, bumps Podfile versions.

This is my best guess at what should happen, after following:
https://dart.dev/null-safety/migration-guide

My ultimate goal is to support https://github.com/fluttercommunity/flutter_sms getting to null safety, and this is a dependency.

@higorlapacw
Copy link

Hey, @jonmountjoy, I don't think this repo is accepting PRs. Why don't you upload this fork into pub.dev and mention the work of @j0j00 as inspiration?

@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'
platform :ios, '9.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these iOS specific changes part of the null safety work?

I don't have an iOS device to test this on, so just curious if this is the best practice in latest Flutter dev or something.

@j0j00
Copy link
Owner

j0j00 commented May 30, 2021

Hi @jonmountjoy,

Thanks for the PR.
Apologies for the late response. I don't really do much Flutter dev lately, and this is kind of a burner github account I check in on every once in a while, hence the lack of updates.

I'm pretty happy to make you a co-maintainer if you want as you seem pretty reputable, but from memory, I think there's still a blocker in terms of Flutter publications as only I can publish packages atm, unless an organisation is set up.

I think I might now be able to add new people as uploaders - which I don't think was available last time I checked a couple of months ago.

Only thing missing from the PR is the appropriate changelog.

@j0j00 j0j00 mentioned this pull request May 30, 2021
@jonmountjoy
Copy link
Author

Thanks @j0j00 - have now moved to a different library. There's a way, on https://pub.dev/ , to mark your package as deprecated/unsupported - perhaps you can do that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants