Implemented extra config builder extension point #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third parties can register extra configuration, given a prefix and an ExtraConfigBuilder. All commands starting with the given prefix will be sent to the matching builder, that will return a custom ExtraSiteConfig object. Implementors are responsible for defining their own ExtraSiteConfig object, as well as their own ExtraConfigBuilder.
j0k3r
reviewed
May 15, 2017
|
Also, don't forget to run |
|
I didn't really clean it up before sending it. The idea was to let you see the big picture. |
I will. Review remarks fixed in the meanwhile. |
j0k3r
reviewed
May 15, 2017
| } else { | ||
| $extraConfigItems[$prefix][$command][] = $val; | ||
| } | ||
| continue 2; |
There was a problem hiding this comment.
Shouldn't this be continue since you remove one level with the first if?
There was a problem hiding this comment.
Nope. A single continue would continue from foreach (array_keys($this->extraConfigBuilders) as $prefix). As we have found an extra config matching the prefix, we want to continue from the next line (foreach ($lines as $line)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third parties can register extra configuration, given a prefix and an
ExtraConfigBuilder.All commands starting with the given prefix will be sent to the matching builder, that will return a custom
ExtraSiteConfigobject.Example:
Implementors are responsible for defining their own ExtraSiteConfig object, as well as their own
ExtraConfigBuilder.