Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VideoGame JsonLD type to exceptions #244

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Conversation

zyuhel
Copy link
Contributor

@zyuhel zyuhel commented Dec 11, 2020

Some resources like Gamespot.com have VideoGame JsonLD objects that available on the page and because they are last, they rewrite correct datatime with incorrect one.

Example:
https://www.gamespot.com/articles/nvidia-rtx-3090-3080-3070-gpu-all-specs-prices-and-release-dates-detailed/1100-6481673/

p.s Maybe there is a good idea to make this list customizable?

@j0k3r j0k3r added this to the 3.0.0 milestone Feb 2, 2022
@coveralls
Copy link

coveralls commented Feb 2, 2022

Coverage Status

Coverage increased (+0.006%) to 95.042% when pulling 3e0cfd5 on zyuhel:patch-1 into d395eeb on j0k3r:master.

@j0k3r
Copy link
Owner

j0k3r commented Feb 2, 2022

Thanks @zyuhel! Sorry for the year of delay 😅
I've updated your PR and added an option to ContentExtractor called json_ld_ignore_types.

@j0k3r j0k3r changed the title Add VideoGame JsonLD type to exceptions Add VideoGame JsonLD type to exceptions Feb 2, 2022
@j0k3r j0k3r merged commit abe816a into j0k3r:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants