Refactored the ContentBuilder out of the ContentExtractor #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure about the message log test, will need to dig a bit deeper to fix the test. |
bdunogier
force-pushed
the
content_builder_refactoring
branch
from
37483e4
to
536001c
Compare
added 2 commits
January 10, 2016 21:01
Conflicts: src/Graby.php
|
The tests pass locally, I'm a bit confused now. Could somebody test ? |
|
And the tests are passing. |
|
I'll have a look later this week 👌 |
|
The HostFingerPrint check the given html and determine the website platform. In the default config, you have: 'fingerprints' => array(
'/\<meta\s*content=\"blogger\"\s*name=\"generator\"/i' => 'fingerprint.blogspot.com',
'/\<meta\s*name=\"generator\"\s*content=\"Blogger\"/i' => 'fingerprint.blogspot.com',
'/\<meta\s*name=\"generator\"\s*content=\"WordPress/i' => 'fingerprint.wordpress.com',
),Which mean, we are looking for that html content (meta blabla) and if we find it we'll apply the value corresponding as the host and then apply the config file (for example) Hope I'm clear :) |
|
Looks good to me, I'll tweaked few things after merge. Can't wait to the future steps in Wallabag :) |
j0k3r
added a commit
that referenced
this pull request
Jan 12, 2016
Refactored the ContentBuilder out of the ContentExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic used in
ContentExtractor::buildSiteConfig()to a new method in theContentBuilder. I have left the HostFingerPrint part in the ContentExtractor, as I'm not 100% sure what it does (feedback welcome).This change makes it possible to build site config objects from anywhere using the host name, as done by http://github.com/wallabag/wallabag in the site login feature PR.
TODO