Added login settings support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,13 @@ class SiteConfig | |||
| // the options below cannot be set in the config files which this class represents | |||
| public $cache_key = null; | |||
|
|
|||
| public $requires_login = false; | |||
There was a problem hiding this comment.
Could you add a comment about how to use them? Like with a short example
There was a problem hiding this comment.
Added description of each setting to the PR. I'll add them to the code, but let me know if you'd like to optimize/change some things first :-)
|
I've relaunched the build and it's OK now. |
|
Is the coverage decrease a blocker ? |
|
Nope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new settings that cover login to a site.
Settings
requires_login: boolean, indicates if the site requires login or not (default: false)not_logged_in_xpath: string, xpath query for an element in articles pages indicating that login is neededlogin_uri: string, the uri to which login data must be POSTedlogin_username_field: string, name of the username field in the formlogin_password_field: string, name of the password field in the formlogin_extra_fields: hash of form field => field value to POST with the login form