Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tidy to suggested dependenies #25

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Add tidy to suggested dependenies #25

merged 1 commit into from
Mar 9, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 16, 2017

No description provided.

@coveralls
Copy link

coveralls commented Feb 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.703% when pulling 669adfb on jtojnar:patch-1 into 445b889 on j0k3r:master.

@j0k3r
Copy link
Owner

j0k3r commented Feb 16, 2017

I'm wondering if I should see the suggestion here or not 🤔
https://travis-ci.org/j0k3r/php-readability/jobs/202260635#L234

Or if the suggestion will only be available inside a package which required the lib

@j0k3r j0k3r mentioned this pull request Mar 9, 2017
Closed
@j0k3r
Copy link
Owner

j0k3r commented Mar 9, 2017

Just tried out using an other package with your fork and it works!

j0k3r/php-readability suggests installing ext-tidy (Used to clean up given HTML and to avoid problems with bad HTML structure.)

Thanks and sorry for taking so long to respond 🙏

@j0k3r j0k3r merged commit 8a91d36 into j0k3r:master Mar 9, 2017
@jtojnar jtojnar deleted the patch-1 branch April 10, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @coveralls @j0k3r