Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require PHP >= 7.2 #69

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Require PHP >= 7.2 #69

merged 2 commits into from
Feb 2, 2022

Conversation

j0k3r
Copy link
Owner

@j0k3r j0k3r commented Jan 10, 2022

  • require PHP 7.2
  • remove test on Composer v1
  • remove deprecated function
  • move loadHtml() into init() instead of __construct

Kinda prepare 2.0 version :)

@coveralls
Copy link

coveralls commented Jan 10, 2022 •
edited

Pull Request Test Coverage Report for Build 1783697696

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 88.474%
Totals Coverage Status
Change from base Build 1591953120: 0.8%
Covered Lines: 545
Relevant Lines: 616
💛 - Coveralls

@j0k3r
Require PHP >= 7.2
66215a6 
- remove test on Composer v1
- remove deprecated function
- move `loadHtml()` into `init()` instead of `__construct`

Kinda prepare 2.0 version :)
@j0k3r j0k3r merged commit 2e9349f into master Feb 2, 2022
@j0k3r j0k3r deleted the feature/php-7.2 branch February 2, 2022 11:53
@j0k3r j0k3r restored the feature/php-7.2 branch February 2, 2022 12:12
@j0k3r j0k3r deleted the feature/php-7.2 branch February 2, 2022 12:13
@j0k3r j0k3r mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j0k3r @coveralls