Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isPhrasingContent conditions, text node replacement #73

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

Kdecherf
Copy link
Contributor

It also disables reverting forced paragraph elements as it can break
layouts or corrupt content.

@coveralls
Copy link

coveralls commented Feb 15, 2022

Pull Request Test Coverage Report for Build 1849092502

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 84.441%

Files with Coverage Reduction New Missed Lines %
src/Readability.php 4 85.78%
Totals Coverage Status
Change from base Build 1794628577: -0.6%
Covered Lines: 597
Relevant Lines: 707

💛 - Coveralls

@j0k3r j0k3r changed the title Fix isPhrasingContent conditions, text node replacement Fix isPhrasingContent conditions, text node replacement Feb 15, 2022
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you can squash 👍

It also disables reverting forced paragraph elements as it can break
layouts or corrupt content.

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf
Copy link
Contributor Author

Squash done @j0k3r

@j0k3r j0k3r merged commit 0c0653d into j0k3r:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants