Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip script and style tags through ::clean() method instead of preg_replace #74

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

Kdecherf
Copy link
Contributor

Huge tags can lead to a failure of preg_replace, thus erasing the whole
fetched content.

E.g.: https://slate.com/news-and-politics/2020/08/joe-biden-empathy-candidate.html

Fixes wallabag/wallabag#5847

…replace

Huge tags can lead to a failure of preg_replace, thus erasing the whole
fetched content.

Fixes wallabag/wallabag#5847

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@j0k3r j0k3r merged commit 5638357 into j0k3r:1.x Jun 13, 2022
@Kdecherf Kdecherf deleted the fix/pre-filters-failure branch June 28, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants