Shouldn't include pthread.h directly in user_malloc.c #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but include THREAD_INCLUDE instead just like chunk_loc.h Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I6b45871351c8effc3a4057ca14152bf078d4dc41
xiaoxiang781216
added a commit
to xiaoxiang781216/dmalloc
that referenced
this pull request
Apr 19, 2021
but include THREAD_INCLUDE instead just like chunk_loc.h Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I6b45871351c8effc3a4057ca14152bf078d4dc41
|
@j256 it look like this patch disappear from the master, should I reopen the PR again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but include THREAD_INCLUDE instead just like chunk_loc.h
since it's important to overwrite the synchronization primitive in RTOS