Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 2차 코드리뷰 반영 #3

Closed
9 tasks done
j2h30728 opened this issue Jun 7, 2023 · 0 comments · Fixed by #4
Closed
9 tasks done

[Refactor] 2차 코드리뷰 반영 #3

j2h30728 opened this issue Jun 7, 2023 · 0 comments · Fixed by #4
Labels
enhancement New feature or request

Comments

@j2h30728
Copy link
Owner

j2h30728 commented Jun 7, 2023 •
edited
Loading

🤸 Describe the required feature

🏊 Todo

  • 식별자 네이밍 변경
    • isGoback => isRootPath 변경
    • char => charactor 변경
    • useGetDetail => useGetCharaterDetailData
  • API URL 에 as const 적용
  • 공통 이미지 컴포넌트의 역할 바로잡기
  • 공통 컨테이너 컴포넌트 제거
  • useFetch 변경
  • 컴포넌트의 추상화단계 조정
@j2h30728 j2h30728 added the enhancement New feature or request label Jun 7, 2023
@j2h30728 j2h30728 mentioned this issue Jun 7, 2023
Merged
6 tasks
j2h30728 added a commit that referenced this issue Jun 9, 2023
@j2h30728
Merge pull request #4 from j2h30728/refactor/#3-refactoring
1b1606c 
[�REFACTORI] 2차 코드 리뷰 반영
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REFACTORI] 2차 코드 리뷰 반영 j2h30728/marvelous
1 participant
@j2h30728