Scheduler Service - Implemented updated REST API and Types #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 8, 2023 14:11
…e service return types to api calls
thoughtpalette
requested review from
EliteScientist,
hecsalazarf,
garethj2 and
riccardoleder
hecsalazarf
requested changes
May 10, 2023
…ents, updated tests with updates
|
@hecsalazarf Thanks for your comments! I've made the requested changes. Please feel free to take another look when you have the opportunity. |
hecsalazarf
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality:
@hecsalazarf Please take extra care when reviewing the Type schemas. I attempted to extract them from the OpenAPI docs as best I could and it's important for implementation that these match as best as possible.