Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving include and exclude patterns #57

Closed
advayDev1 opened this issue May 13, 2015 · 3 comments
Closed

Improving include and exclude patterns #57

advayDev1 opened this issue May 13, 2015 · 3 comments
Assignees
@advayDev1
Labels
type:enhancement
Milestone
Gradle Summit

Comments

@advayDev1
Copy link
Contributor

Per discussion from @brunobowden and @advayDev1, consider changing our include and exclusion patterns to something resembling:
http://gradle.org/docs/current/javadoc/org/gradle/api/tasks/util/PatternFilterable.html

See discussion at #54
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue May 13, 2015
@advayDev1
TODO to address Issue j2objc-contrib#57
6a40d59
brunobowden added a commit that referenced this issue May 13, 2015
@brunobowden
Merge pull request #58 from advayDev1/testDir
bdba5e4 
TODO to address Issue #57
@brunobowden
Copy link
Contributor

Are we going to use sourceSets for this instead?

@brunobowden brunobowden added this to the Gradle Summit milestone Jun 4, 2015
@brunobowden brunobowden self-assigned this Jun 4, 2015
@advayDev1
Copy link
Contributor Author

we are using sourceSets instead. i think you want to assign this to me therefore

@brunobowden brunobowden assigned advayDev1 and unassigned brunobowden Jun 4, 2015
@brunobowden
Copy link
Contributor

Reassigned to @advayDev1

advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
5ff8895 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analagous to translation.

Fixes j2objc-contrib#57, part 1 of j2objc-contrib#52
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
4b900a9 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.

Fixes j2objc-contrib#57, part 1 of j2objc-contrib#52
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
ec054fa 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.

Fixes j2objc-contrib#57 and j2objc-contrib#52
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
23ba7dc 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95
@advayDev1 advayDev1 mentioned this issue Jun 7, 2015
Merged
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
5f14e57 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95

DO NOT SUBMIT - needs merge with j2objc-contrib#109.
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
9a56cb1 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95

DO NOT SUBMIT - needs merge with j2objc-contrib#109.
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
9dba1d7 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95

DO NOT SUBMIT - needs merge with j2objc-contrib#109.
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
6a032ad 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
ba3853a 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57
Fixes j2objc-contrib#52
Fixes j2objc-contrib#95
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
d1ba3e1 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57; Fixes j2objc-contrib#52; Fixes j2objc-contrib#95
Improves j2objc-contrib#85
advayDev1 added a commit to madvay/j2objc-gradle that referenced this issue Jun 7, 2015
@advayDev1
Use SourceSets alone to configure input .java files
09580a9 
- Translation takes main and test java sourceSets
- Translation can be filtered using j2objcConfig.translatePattern
- Test takes test java sourceSet
- Test execution can be filtered using j2objcConfig.testPattern
- Cycle finder is analogous to translation.
- Also makes translation dependent on all possible input files.
- Prohibits incremental translation with --build-closure.

Fixes j2objc-contrib#57; Fixes j2objc-contrib#52; Fixes j2objc-contrib#95
Improves j2objc-contrib#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@advayDev1 advayDev1

Labels
type:enhancement
Projects
None yet
Milestone
Gradle Summit
Development

No branches or pull requests
2 participants
@brunobowden @advayDev1