-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NM plugin fixes #13
Open
wentasah
wants to merge
5
commits into
j4tools:master
Choose a base branch
from
wentasah:fix-nm-ssid-after-resume
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NM plugin fixes #13
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
20bb63d
nm: Use correct type for SSID
wentasah 0bdf161
nm: Use nm_utils_ssid_to_utf8()
wentasah 852e6b0
nm: Suppress unused parameter warnings
wentasah 17e5305
nm: Set data.ssid to NULL after unreferencing
wentasah c00221c
nm: Always refresh SSID after suspend/resume cycle
wentasah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,7 +176,7 @@ typedef struct { | |
} J4statusNmSection; | ||
|
||
static GVariant * | ||
_j4status_nm_format_up_eth_callback(const gchar *token, guint64 value, gconstpointer user_data) | ||
_j4status_nm_format_up_eth_callback(G_GNUC_UNUSED const gchar *token, guint64 value, gconstpointer user_data) | ||
{ | ||
const J4statusNmFormatUpEthData *data = user_data; | ||
switch ( value ) | ||
|
@@ -196,7 +196,7 @@ _j4status_nm_format_up_eth_callback(const gchar *token, guint64 value, gconstpoi | |
} | ||
|
||
static GVariant * | ||
_j4status_nm_format_up_wifi_callback(const gchar *token, guint64 value, gconstpointer user_data) | ||
_j4status_nm_format_up_wifi_callback(G_GNUC_UNUSED const gchar *token, guint64 value, gconstpointer user_data) | ||
{ | ||
const J4statusNmFormatUpWiFiData *data = user_data; | ||
switch ( value ) | ||
|
@@ -220,7 +220,7 @@ _j4status_nm_format_up_wifi_callback(const gchar *token, guint64 value, gconstpo | |
} | ||
|
||
static GVariant * | ||
_j4status_nm_format_down_wifi_callback(const gchar *token, guint64 value, gconstpointer user_data) | ||
_j4status_nm_format_down_wifi_callback(G_GNUC_UNUSED const gchar *token, guint64 value, gconstpointer user_data) | ||
{ | ||
const gint64 *aps_number = user_data; | ||
switch ( value ) | ||
|
@@ -237,7 +237,7 @@ _j4status_nm_format_down_wifi_callback(const gchar *token, guint64 value, gconst | |
} | ||
|
||
static GVariant * | ||
_j4status_nm_format_up_other_callback(const gchar *token, guint64 value, gconstpointer user_data) | ||
_j4status_nm_format_up_other_callback(G_GNUC_UNUSED const gchar *token, guint64 value, gconstpointer user_data) | ||
{ | ||
switch ( value ) | ||
{ | ||
|
@@ -253,13 +253,15 @@ _j4status_nm_format_up_other_callback(const gchar *token, guint64 value, gconstp | |
} | ||
|
||
static GVariant * | ||
_j4status_nm_format_down_other_callback(const gchar *token, guint64 value, gconstpointer user_data) | ||
_j4status_nm_format_down_other_callback(G_GNUC_UNUSED const gchar *token, | ||
G_GNUC_UNUSED guint64 value, | ||
G_GNUC_UNUSED gconstpointer user_data) | ||
{ | ||
return NULL; | ||
} | ||
|
||
static void | ||
_j4status_nm_device_get_addresses_ipv4(J4statusPluginContext *context, NMDevice *device, GVariantBuilder *builder) | ||
_j4status_nm_device_get_addresses_ipv4(G_GNUC_UNUSED J4statusPluginContext *context, NMDevice *device, GVariantBuilder *builder) | ||
{ | ||
NMIPConfig *ip4_config; | ||
|
||
|
@@ -277,7 +279,7 @@ _j4status_nm_device_get_addresses_ipv4(J4statusPluginContext *context, NMDevice | |
} | ||
|
||
static void | ||
_j4status_nm_device_get_addresses_ipv6(J4statusPluginContext *context, NMDevice *device, GVariantBuilder *builder) | ||
_j4status_nm_device_get_addresses_ipv6(G_GNUC_UNUSED J4statusPluginContext *context, NMDevice *device, GVariantBuilder *builder) | ||
{ | ||
NMIPConfig *ip6_config; | ||
|
||
|
@@ -471,7 +473,8 @@ _j4status_nm_device_update(J4statusPluginContext *context, J4statusNmSection *se | |
} | ||
|
||
static void | ||
_j4status_nm_access_point_property_changed(NMAccessPoint *device, GParamSpec *pspec, gpointer user_data) | ||
_j4status_nm_access_point_property_changed(G_GNUC_UNUSED NMAccessPoint *device, | ||
G_GNUC_UNUSED GParamSpec *pspec, gpointer user_data) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: style |
||
{ | ||
J4statusNmSection *section = user_data; | ||
_j4status_nm_device_update(section->context, section, section->device); | ||
|
@@ -496,14 +499,17 @@ _j4status_nm_device_property_changed(NMDevice *device, GParamSpec *pspec, gpoint | |
} | ||
|
||
static void | ||
_j4status_nm_device_state_changed(NMDevice *device, guint state, guint arg2, guint arg3, gpointer user_data) | ||
_j4status_nm_device_state_changed(NMDevice *device, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: style |
||
G_GNUC_UNUSED guint state, | ||
G_GNUC_UNUSED guint arg2, | ||
G_GNUC_UNUSED guint arg3, gpointer user_data) | ||
{ | ||
J4statusNmSection *section = user_data; | ||
_j4status_nm_device_update(section->context, section, device); | ||
} | ||
|
||
static void | ||
_j4status_nm_device_monitor(gpointer key, gpointer data, gpointer user_data) | ||
_j4status_nm_device_monitor(G_GNUC_UNUSED gpointer key, gpointer data, G_GNUC_UNUSED gpointer user_data) | ||
{ | ||
J4statusNmSection *section = data; | ||
|
||
|
@@ -526,7 +532,7 @@ _j4status_nm_device_monitor(gpointer key, gpointer data, gpointer user_data) | |
} | ||
|
||
static void | ||
_j4status_nm_device_unmonitor(gpointer key, gpointer data, gpointer user_data) | ||
_j4status_nm_device_unmonitor(G_GNUC_UNUSED gpointer key, gpointer data, G_GNUC_UNUSED gpointer user_data) | ||
{ | ||
J4statusNmSection *section = data; | ||
|
||
|
@@ -638,7 +644,7 @@ _j4status_nm_section_detach_device(J4statusNmSection *section) | |
} | ||
|
||
static void | ||
_j4status_nm_client_device_added(NMClient *client, NMDevice *device, gpointer user_data) | ||
_j4status_nm_client_device_added(G_GNUC_UNUSED NMClient *client, NMDevice *device, gpointer user_data) | ||
{ | ||
J4statusPluginContext *context = user_data; | ||
J4statusNmSection *section; | ||
|
@@ -648,7 +654,7 @@ _j4status_nm_client_device_added(NMClient *client, NMDevice *device, gpointer us | |
} | ||
|
||
static void | ||
_j4status_nm_client_device_removed(NMClient *client, NMDevice *device, gpointer user_data) | ||
_j4status_nm_client_device_removed(G_GNUC_UNUSED NMClient *client, NMDevice *device, gpointer user_data) | ||
{ | ||
J4statusPluginContext *context = user_data; | ||
J4statusNmSection *section; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: style, all on the same line