This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Handle USB Devices without serial numbers #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial causes of #783
This is unlikely to occur unless the board is very broken, but we should handle this situation anyway.
trickeydan
added
bug
|
Code Climate has analyzed commit 6de1980 and detected 0 issues on this pull request. View more on Code Climate. |
tpoomlmly
approved these changes
Aug 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
semver-major,semver-minororsemver-patchlabel as appropriateWhy do you want to make these changes?
Fix #783
Which parts of the codebase do your changes affect?
Serial and USB discovery
How do your changes affect student or volunteer experience?
This was a bug experienced by a team during SR2022. Due to limitations of how j5 works, we cannot fix it sadly. This prints a warning message or error if the device is known to always have a serial number.
Are your changes related to any existing issues or PRs? How so?
Fixes #783