Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache buster should only be used for JSON #14

Closed
j5py opened this issue Feb 24, 2024 · 0 comments · Fixed by #15
Closed

Cache buster should only be used for JSON #14

j5py opened this issue Feb 24, 2024 · 0 comments · Fixed by #15
Assignees
@j5py
Labels
invalid This doesn't seem right

Comments

@j5py
Copy link
Owner

j5py commented Feb 24, 2024

As a user
I need the logic to load quickly and make sure I have the latest content
So that I can enjoy browsing immediately

Details and Assumptions

  • JavaScript files can be cached, ultimately only JSON content will be modified frequently

Acceptance Criteria

Given the move of the getCacheBuster method and its use on the JSON request only
When the page is reloaded
Then only the JSON file is replaced due to the random value of the query string
@j5py j5py added the invalid This doesn't seem right label Feb 24, 2024
@j5py j5py self-assigned this Feb 24, 2024
@j5py j5py linked a pull request Feb 24, 2024 that will close this issue
Move getCacheBuster in material.js (only JSON) #15
Merged
@j5py j5py closed this as completed in #15 Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j5py j5py

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move getCacheBuster in material.js (only JSON) j5py/j5py.github.io
1 participant
@j5py