feat(config): add support any plugins/presets #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kristinita
pushed a commit
to Kristinita/remark-lint
that referenced
this pull request
Feb 8, 2019
### 1. Summary I add remark integration for Sublime Text and Grunt. ### 2. Details #### 2.1. Grunt grunt-remark [**poorly documented**](https://www.npmjs.com/package/grunt-remark), but successfully works for me with plugins, presets and configurations. #### 2.2. Sublime Text See my [**pull request**](j616/SublimeLinter-contrib-remark-lint#1), it fixes error and add support for any plugin, preset and configuration. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
I change remark command in
linter.py, that:2. Configuration
Remark has many presets and plugins. User can set any custom configuration, see my
.remarkrc.yamlfor example.We shouldn't impose default settings on a single preset on users. I remove
--use remark-preset-lint-markdown-style-guidefromlinter.py.3. Non-errored file
3.1. Behavior before pull-request
File content is copied to output.
3.2. Behavior after pull-request
I add
--no-stdoutoption, that file content not copied to output.4. Testing environment
Thanks.