Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard segms #49

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Discard segms #49

merged 2 commits into from
Dec 4, 2020

Conversation

jGaboardi
Copy link
Owner

This PR addresses #27.

@jGaboardi jGaboardi self-assigned this Dec 4, 2020
@jGaboardi jGaboardi added this to In progress in pre-release build Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #49 (08f81a0) into main (ce0fe4f) will decrease coverage by 0.5%.
The diff coverage is 67.4%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #49     +/-   ##
=======================================
- Coverage   86.5%   86.0%   -0.5%     
=======================================
  Files          5       5             
  Lines       1309    1349     +40     
  Branches     333     344     +11     
=======================================
+ Hits        1132    1160     +28     
- Misses       117     125      +8     
- Partials      60      64      +4     
Impacted Files Coverage Δ
tigernet/generate_data.py 90.7% <64.3%> (-9.3%) ⬇️
tigernet/info.py 76.5% <66.7%> (-23.5%) ⬇️
tigernet/tigernet.py 98.1% <100.0%> (+<0.1%) ⬆️
tigernet/utils.py 81.3% <0.0%> (+0.2%) ⬆️

@jGaboardi jGaboardi merged commit 160da22 into main Dec 4, 2020
@jGaboardi jGaboardi deleted the discard_segms branch December 4, 2020 02:40
@jGaboardi jGaboardi moved this from In progress to Done in pre-release build Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant