Properly clear the alpha discard param in IconComponent & QuadBackgroundComponent #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent and IconComponent when alpha discard is disabled (is set to 0).
Ali-RS
changed the title
|
99% sure that setting alphaDiscardThreshold to 0 is equivalent of disabling it... ie: any of the in-shader ifdefs will be false and so on. |
|
I just followed up based on your comment below that said it is an oversight to not "clear" it. https://hub.jmonkeyengine.org/t/lemur-iconcomponent-issue-with-transparent-icons/45257/10?u=ali_rs I do not have much knowledge about shaders (but By the way, thanks for the response |
|
Ahah. So I'm just trying to be thorough. I'll try to incorporate this the next time I do a pre-release pass. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should properly clean up the alpha discard param in QuadBackgroundComponent and IconComponent when alpha discard is disabled (is set to 0).