Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PQTorus Rendering Glitch #1121

Closed
louhy opened this issue Jun 13, 2019 · 3 comments
Closed

PQTorus Rendering Glitch #1121

louhy opened this issue Jun 13, 2019 · 3 comments
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Milestone
v3.2.4

Comments

@louhy
Copy link
Contributor

louhy commented Jun 13, 2019

PQTorus vanishes when you're not looking at it directly. Looks like world bounds aren't updated after the vertex buffer is set:
https://vimeo.com/341919874

Suggest adding an updateBound() call at the end of updateGeometry() within PQTorus.java:

        ...
        setBuffer(Type.Position, 3, fpb);
        setBuffer(Type.Normal,   3, fnb);
        setBuffer(Type.TexCoord, 2, ftb);
        setBuffer(Type.Index,    3, sib);
        
        updateBound();
    }
@stephengold
Copy link
Member

Good catch!

louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 13, 2019
@louhy
jMonkeyEngine#1121-updateBound() call for PQTorus geometry updates
4580344
@louhy louhy mentioned this issue Jun 13, 2019
Merged
louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 16, 2019
@louhy
World bounds test added for jMonkeyEngine#1121
ae38f68
louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 16, 2019
@louhy
World bounds test enhancements for jMonkeyEngine#1121
d8055f6
stephengold pushed a commit that referenced this issue Jun 18, 2019
@louhy @stephengold
#1121-updateBound() call for PQTorus geometry updates (#1122)
1f3245b 
* #1121-updateBound() call for PQTorus geometry updates

* World bounds test added for #1121

* World bounds test enhancements for #1121

* Updated test comment
@stephengold
Copy link
Member

@louhy Your fix is integrated. Please verify that the glitch is gone from master branch.

@louhy
Copy link
Contributor Author

louhy commented Jun 19, 2019

@stephengold Works here!

@stephengold stephengold modified the milestones: v3.3.0, v3.2.4 Jun 19, 2019
stephengold pushed a commit that referenced this issue Jul 10, 2019
@louhy @stephengold
#1121-updateBound() call for PQTorus geometry updates (#1122)
341117d 
* #1121-updateBound() call for PQTorus geometry updates

* World bounds test added for #1121

* World bounds test enhancements for #1121

* Updated test comment
@stephengold stephengold added the bug Something that is supposed to work, but doesn't. More severe than a "defect". label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Projects
None yet
Milestone
v3.2.4
Development

No branches or pull requests
2 participants
@stephengold @louhy