Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PQTorus Rendering Glitch #1121

Closed
louhy opened this issue Jun 13, 2019 · 3 comments

Comments

@louhy
Copy link
Contributor

commented Jun 13, 2019

PQTorus vanishes when you're not looking at it directly. Looks like world bounds aren't updated after the vertex buffer is set:
https://vimeo.com/341919874

Suggest adding an updateBound() call at the end of updateGeometry() within PQTorus.java:

        ...
        setBuffer(Type.Position, 3, fpb);
        setBuffer(Type.Normal,   3, fnb);
        setBuffer(Type.TexCoord, 2, ftb);
        setBuffer(Type.Index,    3, sib);
        
        updateBound();
    }
@stephengold

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Good catch!

louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 13, 2019

louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 16, 2019

louhy added a commit to louhy/jmonkeyengine that referenced this issue Jun 16, 2019

stephengold added a commit that referenced this issue Jun 18, 2019

#1121-updateBound() call for PQTorus geometry updates (#1122)
* #1121-updateBound() call for PQTorus geometry updates

* World bounds test added for #1121

* World bounds test enhancements for #1121

* Updated test comment
@stephengold

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@louhy Your fix is integrated. Please verify that the glitch is gone from master branch.

@louhy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@stephengold Works here!

@stephengold stephengold modified the milestones: v3.3.0, v3.2.4 Jun 19, 2019

stephengold added a commit that referenced this issue Jul 10, 2019

#1121-updateBound() call for PQTorus geometry updates (#1122)
* #1121-updateBound() call for PQTorus geometry updates

* World bounds test added for #1121

* World bounds test enhancements for #1121

* Updated test comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.