Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationMask is not dispatched to internal actions #1199

Closed
Ali-RS opened this issue Oct 9, 2019 · 1 comment
Closed

AnimationMask is not dispatched to internal actions #1199

Ali-RS opened this issue Oct 9, 2019 · 1 comment
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Milestone

Comments

@Ali-RS
Copy link
Member

Ali-RS commented Oct 9, 2019

Here in this line

where the mask is set to running action in the layer, it does not dispatch the mask to child actions as well.
Actually, we can set a mask to each child action separately when we create it but my understanding is the mask is supposed to be provided directly from AnimComposer to the whole action including the chained actions. This means that internal actions can not have a different mask.

If my assumption is true then following method on 'Action'

public void setMask(AnimationMask mask) {
this.mask = mask;
}

should be changed to this

this.mask = mask;
for(Action action : actions) {
     action.setMask(mask);
}

I can make a PR if everyone is agree with this change.

@Ali-RS Ali-RS changed the title AnimComposer: AnimationMask is not dispatched to child actions AnimationMask is not dispatched to child actions Oct 9, 2019
@Ali-RS Ali-RS changed the title AnimationMask is not dispatched to child actions AnimationMask is not dispatched to internal actions Oct 9, 2019
@stephengold stephengold added this to the v3.3.0 milestone Oct 10, 2019
@stephengold stephengold modified the milestones: v3.3.0, Future Release Apr 16, 2020
@Ali-RS
Copy link
Member Author

Ali-RS commented Aug 28, 2022

Fixed in #1845.

@Ali-RS Ali-RS closed this as completed Aug 28, 2022
@Ali-RS Ali-RS modified the milestones: Future Release, v3.6.0 Dec 31, 2022
@Ali-RS Ali-RS added bug Something that is supposed to work, but doesn't. More severe than a "defect". and removed To be investigated labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Projects
None yet
Development

No branches or pull requests

2 participants