iOS gl3 and some improvements #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync fork
Update fork
… in the atlases instead of setting a predefined byte buffer on disposal that made all atlases in the backend use the same buffer and generated rendering issues.
Fork update
…d more images to the screens so it really uses more atlases
Update fork PR
Update fork
Created native methods in JmeIosGLES
…th v52 but when executing it failed to find methods of nio.*Buffer because of an implementation change after java 1.9
…ing any additional framebuffer (scene processors and filters)
stephengold
changed the title
Ali-RS
reviewed
Feb 25, 2021
jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Outdated
Show resolved
Hide resolved
MeFisto94
reviewed
Mar 1, 2021
| JmeIosGLES.glFramebufferTextureLayer(target, attachment, texture, level, layer); | ||
| } | ||
|
|
||
| // New methods from GL2 interface which are supported in GLES30 |
There was a problem hiding this comment.
Supported or unsupported? given that they are stubs atm
There was a problem hiding this comment.
The comment is not too clear... Methods below are those defined in GL2 which we need to implement because gles30 supports some of them like GL{Read|Write}Buffer and also 3D textures. The reason to create the stubs is that glAlphaFunc, glPointSize and glPolygonMode have no gles equivalent but are defined in GL2 interface.
|
Going to merge this in the next 24H if there is no objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the list of changes:
Topic at hub: https://hub.jmonkeyengine.org/t/ios-improvements-including-gles3-0/44332
** This PR needs the related SDK PR: jMonkeyEngine/sdk#295