Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLBLoader load much more into memory than GLTF equivalent. #2127

Closed
oxplay2 opened this issue Oct 23, 2023 · 0 comments · Fixed by #2128
Closed

GLBLoader load much more into memory than GLTF equivalent. #2127

oxplay2 opened this issue Oct 23, 2023 · 0 comments · Fixed by #2128
Assignees
@tonihele
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Milestone
Future Release

Comments

@oxplay2
Copy link

oxplay2 commented Oct 23, 2023 •
edited

related to post:

Tonihele were able to load Bistro scene as GLTF, but GLB caused to exceed 32 GB memory.

Worth to investigate.

As Tonihele suggested, issue might be related to this file(that extends working GLTF):
https://github.com/jMonkeyEngine/jmonkeyengine/blob/c9d10eb6ffcebbf18a7709de15be1eac67de9c1f/jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/GlbLoader.java
@tonihele tonihele self-assigned this Oct 23, 2023
@tonihele tonihele mentioned this issue Oct 23, 2023
Merged
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Oct 24, 2023
@stephengold stephengold added this to the Future Release milestone Oct 25, 2023
stephengold pushed a commit that referenced this issue Oct 28, 2023
@tonihele
Solve issue #2127 (excessive memory use while loading GLB) (#2128)
300d2a7 
* Cache the materials

* Try with resources to make sure we close the stream

* Conform cache naming to the other cache usages

* Just use the cache in the read method as the other caches do

* Clone the material

* Cache textures locally to avoid embedded textures to be read many times
@tonihele tonihele mentioned this issue Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonihele tonihele

Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Milestone
Future Release
3 participants
@stephengold @tonihele @oxplay2