-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lights : added light v. sphere intersection #364
Conversation
…and implementations of intersectsSphere(), second attempt
We have some unit tests for the light culling here: Could you include a test case for a model which uses a bounding sphere? |
Yes, i'll add this when i have time. |
…rsections (for lightFilter)
I could also move the code for collision of sphere v. sphere (and v. cone) into Intersection.java , what do you think ? |
@dokthar If you think it makes sense to share that code between bounding volumes and lights then go ahead. |
@shadowislord I agree that's feel strange to put the sphere v. cone collision code inside Intersection, as it's need a lot of parameters (already computed inside the cone light). |
Don't merge this yet, one test case is wrong, i am trying to fix this. |
@shadowislord : I don't have more changes comming so you can review this. |
Lights : added light v. sphere intersection
(see DefaultLightFilter does not support BoundingSphere #362)