Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lights : added light v. sphere intersection #364

Merged
merged 4 commits into from
Oct 24, 2015

Conversation

dokthar
Copy link
Contributor

@dokthar dokthar commented Oct 7, 2015

…and implementations of intersectsSphere(), second attempt
@shadowislord
Copy link
Member

We have some unit tests for the light culling here:
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/test/java/com/jme3/light/LightFilterTest.java

Could you include a test case for a model which uses a bounding sphere?

@dokthar
Copy link
Contributor Author

dokthar commented Oct 10, 2015

Yes, i'll add this when i have time.

@dokthar
Copy link
Contributor Author

dokthar commented Oct 14, 2015

I could also move the code for collision of sphere v. sphere (and v. cone) into Intersection.java , what do you think ?

@shadowislord
Copy link
Member

@dokthar If you think it makes sense to share that code between bounding volumes and lights then go ahead.

@dokthar
Copy link
Contributor Author

dokthar commented Oct 15, 2015

@shadowislord I agree that's feel strange to put the sphere v. cone collision code inside Intersection, as it's need a lot of parameters (already computed inside the cone light).
Also I found that the collision code used for sphere v. sphere was already wrote (inside Intersection), so i use this one.

@dokthar
Copy link
Contributor Author

dokthar commented Oct 16, 2015

Don't merge this yet, one test case is wrong, i am trying to fix this.

@dokthar
Copy link
Contributor Author

dokthar commented Oct 23, 2015

@shadowislord : I don't have more changes comming so you can review this.

shadowislord added a commit that referenced this pull request Oct 24, 2015
Lights : added light v. sphere intersection
@shadowislord shadowislord merged commit edaf49c into jMonkeyEngine:master Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants