Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoneTrack.clone() adds scales #829

Closed
stephengold opened this issue Feb 23, 2018 · 3 comments
Closed

BoneTrack.clone() adds scales #829

stephengold opened this issue Feb 23, 2018 · 3 comments
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Milestone

Comments

@stephengold
Copy link
Member

When a BoneTrack with scales == null is cloned, the result is a track with scales != null. While this behavior doesn't change the appearance of the animation, it is unexpected and unnecessary.

@pspeed42
Copy link
Contributor

pspeed42 commented Feb 23, 2018 via email

@stephengold
Copy link
Member Author

BoneTrack isn't even JmeCloneable, so it's setting a bad example for others.

@stephengold
Copy link
Member Author

PR#830 should've fixed this.

@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Dec 16, 2018
@stephengold stephengold added this to the v3.2.2 milestone Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Development

No branches or pull requests

2 participants