Github Actions: Implement a "Mesa Compliance Testing" #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/MeFisto94/jme3-testing that runs functional tests on a software renderer to validate rendering works correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using https://github.com/MeFisto94/jme3-testing that runs functional tests on a software renderer to validate rendering works correctly.
Scope
This is only the tracking PR about the Github Actions integration of this feature. Anything related to the feature itself may happen on the hub topic https://hub.jmonkeyengine.org/t/help-testing-jmonkeyengine/42856 or the jme3-testing repository.
Note: Currently when merging the PR, none of the tests will work, because they all time out, which means app.stop isn't called correctly. This used to work on an older revision of the engine, maybe context changes have caused the issue, I will investigate it, but it's unrelated to this PR basically.
Security
In theory jme3-testing and the buildenvs should use specific commit hashes to protect against their maintainers introducing evil code (or host them into the main organization, also from the aspect of it not disappearing), since this is a dedicated workflow, unrelated to releasing binaries or something, only the second aspect may be worth considering.
I'll move this PR in draft state until the issues in jme3-testing have been solved, feel free to comment on both this and jme3-testing in general.
Edit: Feel free to try jme3-testing locally, for me it almost works (
testSimpleBlueCube10sDebugStatsfails for lwjgl2), so it's something with the headless environment again.