Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve issue #1596 (missing check for GLFW_KEY_UNKNOWN) #1638

Merged
merged 1 commit into from Nov 11, 2021
Merged

solve issue #1596 (missing check for GLFW_KEY_UNKNOWN) #1638

merged 1 commit into from Nov 11, 2021

Conversation

stephengold
Copy link
Member

This addresses the issue by returning null if the key is unknown.

@stephengold stephengold linked an issue Nov 5, 2021 that may be closed by this pull request
GlfwKeyInput.getKeyName() doesn't check for GLFW_KEY_UNKNOWN #1596
Closed
@stephengold stephengold added this to the v3.5.0 milestone Nov 5, 2021
@stephengold
Copy link
Member Author

I plan to integrate this in about 24 hours.

@stephengold stephengold merged commit de4de00 into master Nov 11, 2021
@stephengold stephengold deleted the sgold-issue1596 branch November 11, 2021 06:20
@stephengold stephengold changed the title solve issue #1696 (missing check for GLFW_KEY_UNKNOWN) solve issue #1596 (missing check for GLFW_KEY_UNKNOWN) Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

GlfwKeyInput.getKeyName() doesn't check for GLFW_KEY_UNKNOWN
1 participant
@stephengold