Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve issue #2023 (getRotationColumn() returns wrong result) #2024

Merged
merged 4 commits into from
Jun 1, 2023
Merged

solve issue #2023 (getRotationColumn() returns wrong result) #2024

merged 4 commits into from
Jun 1, 2023

Conversation

stephengold
Copy link
Member

An automated testcase is included, to detect future regressions.

@stephengold stephengold added this to the Future Release milestone May 28, 2023
@stephengold stephengold added the bug Something that is supposed to work, but doesn't. More severe than a "defect". label May 28, 2023
@stephengold stephengold linked an issue May 28, 2023 that may be closed by this pull request
getRotationColumn() may return incorrect results #2023
Closed
@stephengold
Copy link
Member Author

Oops! Now LightFilterTest is failing. The camera orientation gets set to an impossible value at line 137: look direction and up direction are the same! Based on the comments, I don't believe this was intentional, so I will alter the test.

@stephengold stephengold modified the milestones: Future Release, v3.6.1 May 29, 2023
@stephengold
Copy link
Member Author

Unless there's substantial discussion, I plan to integrate this change in about 24 hours.

@stephengold stephengold merged commit 2a62f06 into master Jun 1, 2023
14 checks passed
@stephengold stephengold deleted the sgold/issue/2023 branch June 1, 2023 04:13
@stephengold
Copy link
Member Author

On further consideration, it's quite possible existing apps rely on the incorrect result. Postpone this until 3.7 or 4.0 .

@stephengold stephengold modified the milestones: v3.6.1, Future Release Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect".
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.

getRotationColumn() may return incorrect results
1 participant
@stephengold