Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #2082 (AlphaBlendModeTest) #2084

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Fixes Issue #2082 (AlphaBlendModeTest) #2084

merged 5 commits into from
Oct 25, 2023

Conversation

codex128
Copy link
Contributor

@codex128 codex128 commented Oct 8, 2023

Fixes issues loading blend modes and alpha discard levels on gltf models as described in #2082.

@stephengold stephengold added this to the Future Release milestone Oct 8, 2023
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Oct 8, 2023
@stephengold stephengold linked an issue Oct 8, 2023 that may be closed by this pull request
jme3-plugins imports Alpha Blend Mode Test incorrectly #2082
Closed
@stephengold
Copy link
Member

Thanks for your work. A couple changes, please:

  • The "AlphaBlendModeTest" data is licensed CC-BY 4.0, which is not compatible with JME's license. Either create new test data or delete the test.
  • There should be no line break after a brace that is followed by else. Delete those line breaks.

@stephengold stephengold changed the title Fixes Issue #2082 Fixes Issue #2082 (AlphaBlendModeTest) Oct 15, 2023
@riccardobl riccardobl added the hacktoberfest-accepted PRs that are Hacktoberfest valid (Optional if PR is merged or approved during the month of october) label Oct 16, 2023
@stephengold
Copy link
Member

Unless there is further substantive discussion, I plan to integrate this PR in about 48 hours.

@stephengold stephengold merged commit d89e379 into jMonkeyEngine:master Oct 25, 2023
14 checks passed
@stephengold
Copy link
Member

Thanks for the contribution, @codex128 !

@stephengold stephengold mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengold stephengold stephengold left review comments

Assignees
No one assigned
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug" hacktoberfest-accepted PRs that are Hacktoberfest valid (Optional if PR is merged or approved during the month of october)
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.

jme3-plugins imports Alpha Blend Mode Test incorrectly
3 participants
@codex128 @stephengold @riccardobl