implement equals(), hashCode(), and isSimilar() for bounding volumes #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
force-pushed
the
sgold/issue/2249
branch
from
94b52ef
to
aa55d7f
Compare
|
@pspeed42: If you've got a moment, I'd like your opinion on whether |
|
It probably should ignore... but probably also that's up to the class that contains the field. It would maybe be more forward-thinking of these subclasses called super.equals() and super.hashCode() as part of their processing rather than hoping to grab the right fields from the super class (which in my opinion should have been private fields in the first place... but that's a different religious hill to die on another day). |
|
Thanks for your insights, Paul. |
stephengold
force-pushed
the
sgold/issue/2249
branch
from
3177879
to
37375bb
Compare
|
ready for review |
scenemax3d
pushed a commit
that referenced
this pull request
Jun 11, 2024
…2252) * implement equals() and hashCode() for BoundingBox * implement equals() and hashCode() for BoundingSphere * implement isSimilar() for BoundingBox * implement isSimilar() for BoundingSphere * BoundingSphere: add comments to emphasize the treatment of checkPlane * TestBoundingSphere: test equals() and isSimilar() * jme3-core tests: add the TestBoundingBox class * BoundingVolume: add equals() and hashCode() methods * utilize super.equals() and super.hashCode() * refactor to utilize Objects.hash()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the enhancements request in issue #2249.
Since the PR overrides
equals(), it must also overridehashCode()because the contract ofhashCode()specifies that objects that are equal must return the same code.The new methods intentionally ignore the
checkPlanefield, which holds auxiliary data used by theCameraclass.