Added sweepTest to jme3-bullet-native #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This lookes fine for me, @normen what do you think about this? |
|
I can confirm TestSweepTest works, however, it seems the sweep test returns the object being sweeped as well (meaning, the capsule shape). This behavior doesn't seem to occur with JBullet. Currently investigating ... |
|
I changed TestSweepTest so it ignores the shape being sweeped. This is a behavior difference between JBullet and native bullet that needs to be accounted for. |
|
Its okay the way it is but you copied the ugly way the other hit results are copied to java (addResult/addSweepResult), which was done as a contribution.. I wanted to change how this is handled, guess its my fault for keeping this bad example in ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.