Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bone animation bind transform bug #435

Merged

Conversation

AlrikG
Copy link
Contributor

@AlrikG AlrikG commented Mar 1, 2016

The constructor doesn't "Only copies the name and bind pose from the original.". It takes the object references from the original which leads to shared bind transforms.

For example several same models are loaded and each model should have different e.g. arm sizes. If all models shares the same bind object references, all models have the same arm size instead of different ones.

A simple clone() makes a real copy and fixes this problem. Now its prossible to have different sized and bone animated arms.

Hint:

enabling UserControl disable bone animations, so this is not the way I want. I want bone affected by animations and customized bone transforms (bind transforms).

Forum link: http://hub.jmonkeyengine.org/t/bug-bone-animations-share-their-bind-transforms/35217

@shadowislord
Copy link
Member

@AlrikG
Copy link
Contributor Author

AlrikG commented Mar 2, 2016

Yes you are right. I fixed it

@AlrikG
Copy link
Contributor Author

AlrikG commented Mar 2, 2016

I have added a more precise comment because the constructor does more than the comment said

shadowislord added a commit that referenced this pull request Mar 2, 2016
@shadowislord shadowislord merged commit 2f218f0 into jMonkeyEngine:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants